-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Remaining sparse semiring distances #261
Merged
rapids-bot
merged 68 commits into
rapidsai:branch-21.08
from
cjnolet:semiring_primitive_additional_distances
Jul 12, 2021
Merged
Changes from 62 commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
5b28699
moving sparse dist optim to raft
divyegala 8e841ac
bucketing bloom filter
divyegala efcf972
trying stuff
divyegala 8f5cc26
dropping tpb as template in strategies
divyegala 78aff5a
New distances
cjnolet 9aa58f2
Uncommenting hash strategy
cjnolet cf57c9f
Udating hash strategy
cjnolet 530dd87
Updating to add hash table and bloom strategies
cjnolet 62b3df4
Updates
cjnolet 28d6e2d
More updates
cjnolet c79ee7a
Updating hash strategy
cjnolet e5d93dd
Merge branch 'branch-0.19' into HEAD
cjnolet 628b169
Updates
cjnolet fc708a9
Merge branch 'branch-0.19' into fea-020-sparse_spmv_optim
cjnolet d9ecc40
trying to merge chunking bug fixes
divyegala d299cb8
correcting int to value_idx
divyegala 900ad8c
correction to expansion and start index
divyegala 634bc99
Adding correlation distance
cjnolet 82cdbe1
Baseline
cjnolet 4e819c0
Enabling baseline
cjnolet 6bd450f
Enabling optimized primitive
cjnolet f1c1d06
Fixing style
cjnolet 219a813
Cleanup
cjnolet 0fee984
Style
cjnolet b7105d7
Removing unecessary deltas
cjnolet e264514
Updating distances_config_t to use handle directly
cjnolet 65f82bd
Merge branch 'branch-0.20' into semiring_primitives_optim_final
cjnolet 2975fe3
Adding tests for newer distances
cjnolet 0d064cc
NOrmalizing
cjnolet 2057985
Separating new distances from optimizations
cjnolet 3a669f5
Fixing style
cjnolet a415ebf
Merge branch 'branch-21.06' into semiring_primitives_optim_final
cjnolet 99b4e14
Trying to get cuco working
cjnolet 46c7d10
Removing dependencies.cmake
cjnolet ef9efa7
Raft is building all gpu archs. Checking this in the meantime
cjnolet a9d3608
changing cuo to dev branch
divyegala d613a77
working through build
divyegala 2394084
fixing build
divyegala 09b5b2c
Updating correlation
cjnolet 339ae67
Merge branch 'semiring_primitives_optim_final' into semiring_primitiv…
cjnolet b40d7ce
Corr updates
cjnolet d0e0ea7
Yes! Correlation distance works!
cjnolet 2d3855d
Adding russelrao dist
cjnolet 69ff625
tests passing for all strategies
divyegala 67562a0
Adding russelrao
cjnolet c43c496
Merge branch 'semiring_primitives_optim_final' into semiring_primitiv…
cjnolet 149d67f
Getting tests to work for russellrao
cjnolet deb01b2
Adding hamming distance
cjnolet fad730a
Adding jensenshannon and kldivergence
cjnolet c97e8e4
Testing remaining distances
cjnolet 7739d1f
integrating cuco changes and some small refactors
divyegala 1098d89
merging upstream
divyegala a3e263b
removing thrust::device_vector usage because stream unsafe
divyegala b991081
Merge branch 'branch-21.08' of https://github.com/rapidsai/raft into …
divyegala 6ef7a02
restructuring tests and addressing review related to tests
divyegala 9b63fc8
addressing other review comments
divyegala a270833
Merge branch 'branch-21.08' of https://github.com/rapidsai/raft into …
divyegala cca6fa6
pointing back to dev cuco commit
divyegala 6c2f707
Merge branch 'branch-21.08' of https://github.com/rapidsai/raft into …
divyegala ea597d6
removing print
divyegala 318a95a
Merge remote-tracking branch 'divye/semiring_primitives_optim_final' …
cjnolet 591f9f2
Merge branch 'branch-21.08' into semiring_primitive_additional_distances
cjnolet fc185e5
Additional consts needed
cjnolet 924d8db
Using rmm::device_uvector
cjnolet 72dd60e
More removal of device buffer
cjnolet cc59ad6
Merge branch 'branch-21.08' of github.com:rapidsai/raft into branch-2…
cjnolet 1da9ef0
Merge branch 'branch-21.08' of github.com:rapidsai/raft into branch-2…
cjnolet 6e68e40
Merge branch 'branch-21.08' into semiring_primitive_additional_distances
cjnolet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it wouldn't be too many changes, could you use rmm uvectors in general instead? (just adding a single comment to avoid repeated ones)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I don't think that would be too much to do for this PR.