Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cuda_suffixed: true #2440

Merged

Conversation

trxcllnt
Copy link
Collaborator

This change ensures rmm-cuXX is not in the package dependencies when building the pylibraft wheel with -C "rapidsai.matrix-entry=cuda_suffixed=false.

@trxcllnt trxcllnt requested a review from a team as a code owner September 18, 2024 22:04
@trxcllnt trxcllnt added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 18, 2024
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Thank you for this.

@jameslamb
Copy link
Member

/merge

@jameslamb
Copy link
Member

I tried re-running CI here multiple times... it's failed in the same way each time (and I see other PRs and nightlies failing the same way).

Opened #2450 documenting that.

@jameslamb
Copy link
Member

Updated to pull in #2453, which temporarily skips one failing test that was blocking this (and because this was now too many commits behind branch-24.10 to pass the Recently Updated check).

@rapids-bot rapids-bot bot merged commit 2e705fb into rapidsai:branch-24.10 Sep 26, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants