-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fmt (to 11.0.2) and spdlog (to 1.14.1). #2433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
non-breaking
Non-breaking change
improvement
Improvement / enhancement to an existing function
labels
Sep 16, 2024
7 tasks
We have some errors like this:
These may need to be suppressed like this: raft/cpp/include/raft/util/memory_type_dispatcher.cuh Lines 187 to 189 in ac53a0f
|
…e narrowed down / upstreamed before merging)
…should be narrowed down / upstreamed before merging)" This reverts commit 3ba2201.
jameslamb
added
3 - Ready for Review
5 - DO NOT MERGE
Hold off on merging; see PR for details
labels
Sep 19, 2024
jameslamb
changed the title
WIP: [DO NOT MERGE] Update fmt (to 11.0.2) and spdlog (to 1.14.1).
Update fmt (to 11.0.2) and spdlog (to 1.14.1).
Sep 19, 2024
bdice
approved these changes
Sep 20, 2024
jameslamb
commented
Sep 20, 2024
NAMESPACE spdlog::) | ||
include("${rapids-cmake-dir}/export/find_package_root.cmake") | ||
rapids_export_find_package_root(BUILD spdlog [=[${CMAKE_CURRENT_LIST_DIR}]=] EXPORT_SET rmm-exports) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context for this change: rapidsai/rapids-cmake#387 (comment)
jameslamb
removed
3 - Ready for Review
5 - DO NOT MERGE
Hold off on merging; see PR for details
labels
Sep 23, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CMake
cpp
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#56
Now that most of
conda-forge
has been updated tofmt >=11.0.1,<12
andspdlog>=1.14.1,<1.15
(rapidsai/build-planning#56 (comment)), we're attempting to upgrade RAPIDS to similar versions of those libraries.This improves the likelihood that RAPIDS will be installable alongside newer versions of its
dependencies and complementary packages on conda-forge.
Notes for Reviewers
This PR is testing changes made in rapidsai/rapids-cmake#689.
It shouldn't be merged until those
rapids-cmake
changes are merged and anytesting-specific details have been removed.