Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix bitset function visibility #2429

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Sep 6, 2024

raft::ceildiv is also being replaced with raft::div_rounding_up_safe to avoid including CUDA headers when not needed.

@lowener lowener requested a review from a team as a code owner September 6, 2024 14:38
@github-actions github-actions bot added the cpp label Sep 6, 2024
@lowener lowener added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Sep 6, 2024
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowener
Copy link
Contributor Author

lowener commented Sep 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit ac53a0f into rapidsai:branch-24.10 Sep 10, 2024
60 checks passed
@lowener lowener deleted the 24.10-bitset-fix branch September 10, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants