Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip CMake 3.30.0 #2375

Merged
merged 2 commits into from
Jul 5, 2024
Merged

skip CMake 3.30.0 #2375

merged 2 commits into from
Jul 5, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#80

Adds constraints to avoid pulling in CMake 3.30.0, for the reasons described in that issue.

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 5, 2024
@jameslamb jameslamb changed the title skip CMake 3.30.0 avoid CMake 3.30.0 Jul 5, 2024
@jameslamb
Copy link
Member Author

I'd pushed another commit because I thought that maybe using "skip" had led to CI not running.

But I think it's just because there's an ongoing incident with GitHub webhooks: https://www.githubstatus.com/incidents/5yx1d67vq9hg

Webhooks is experiencing degraded availability.

@jameslamb jameslamb changed the title avoid CMake 3.30.0 skip CMake 3.30.0 Jul 5, 2024
@github-actions github-actions bot added the python label Jul 5, 2024
@jameslamb jameslamb marked this pull request as ready for review July 5, 2024 21:15
@jameslamb jameslamb requested a review from a team as a code owner July 5, 2024 21:15
@jameslamb jameslamb requested a review from AyodeAwe July 5, 2024 21:15
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 4d7a39c into rapidsai:branch-24.08 Jul 5, 2024
72 checks passed
@jameslamb jameslamb deleted the cmake-pin branch July 5, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants