Fix compilation error when _CLK_BREAKDOWN is defined in cagra. #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @enp1s0 , can you please review this PR and add labels for Label Checker CI? |
PR rapidsai#1740 forgot to rename `BLOCK_SIZE` in `#ifdef _CLK_BREAKDOWN` blocks. The use of `RAFT_LOG_DEBUG` in kernel function results in compilation errors, replace it with `printf`. Also remove an unused function in search_single_cta_kernel-inl.cuh
jiangyinzuo
force-pushed
the
fix-block-size
branch
from
ae78ee9 to
0537118
Compare
enp1s0
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
Thank you @jiangyinzuo for the PR. It looks good to me. Sorry for forgetting to update the clock measurement code in my previous PR.
|
@cjnolet Can you run the CI? |
|
/ok to test |
|
/ok to test |
|
@tfeher I fixed the code style error reported by |
|
/ok to test |
tfeher
approved these changes
Jun 10, 2024
Is the failure related to this PR? |
|
@cjnolet Yes, it is needed. As mentioned in the PR description, this PR will be ported to cuVS after this PR is merged. |
|
/ok to test |
|
I have created a PR for cuvs, see rapidsai/cuvs#202 |
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Jul 2, 2024
Port from rapidsai/raft#2350 Authors: - Yinzuo Jiang (https://github.com/jiangyinzuo) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1740 forgot to rename
BLOCK_SIZEin#ifdef _CLK_BREAKDOWNblocks.The use of
RAFT_LOG_DEBUGin kernel function results in compilationerrors, replace it with
printf.Also remove an unused function in search_single_cta_kernel-inl.cuh
After merging: