Rename raft-ann-bench module to raft_ann_bench #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of setuptools require the version attribute to be a valid Python identifier. Replace hyphens with underscores in raft-ann-bench to make it a valid Python identifier. Also add a Python 3.11 tag to raft-ann-bench.
divyegala
added
bug
divyegala
approved these changes
May 23, 2024
msarahan
approved these changes
May 23, 2024
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 24, 2024
Change the imported package name to reflect the new name as of #2333. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Bradley Dice (https://github.com/bdice) - Divye Gala (https://github.com/divyegala) URL: #2338
rapids-bot bot
pushed a commit
to rapidsai/docker
that referenced
this pull request
May 24, 2024
Depends on rapidsai/raft#2333 Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Bradley Dice (https://github.com/bdice) - Jake Awe (https://github.com/AyodeAwe) URL: #671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hyphens with underscores in
raft-ann-benchto make it a valid Python identifier. Also add a Python 3.11 tag toraft-ann-bench, and use theVERSIONfile instead of an attribute.