[FEA] Split Bitset code #2295
Merged
[FEA] Split Bitset code #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mickael Ide <[email protected]>
lowener
added
3 - Ready for Review
feature request
|
/merge |
abc99lr
pushed a commit
to abc99lr/raft
that referenced
this pull request
May 10, 2024
Splitting the Bitset code into a `.hpp` and `.cuh` header allow the declaration of `ann::search_with_filters` with a `bitset_filter` to be made without using CUDA code in headers. This is useful for cuVS where the headers `ivf_pq.hpp` need to declare `search_with_filter` and stay CUDA-free. Authors: - Micka (https://github.com/lowener) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#2295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the Bitset code into a
.hppand.cuhheader allow the declaration ofann::search_with_filterswith abitset_filterto be made without using CUDA code in headers.This is useful for cuVS where the headers
ivf_pq.hppneed to declaresearch_with_filterand stay CUDA-free.