Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nvtx3 link in cmake #2246

Merged
merged 8 commits into from
May 9, 2024
Merged

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Mar 26, 2024

  • Link to nvtx3 instead of deprecated nvToolsExt
  • Use LAZY cmake install message, to avoid flooding the console with all the headers name when they are left untouched.

@lowener lowener requested a review from a team as a code owner March 26, 2024 16:12
@lowener lowener added 3 - Ready for Review non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 2, 2024
@robertmaynard
Copy link
Contributor

The CMAKE_INSTALL_MESSAGE currently breaks rapids-cmake infrastructure to generate installable tests, so that needs to be removed.

@lowener
Copy link
Contributor Author

lowener commented May 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit d11e78a into rapidsai:branch-24.06 May 9, 2024
61 checks passed
@lowener lowener deleted the 24.06-nvtx3 branch May 9, 2024 12:57
abc99lr pushed a commit to abc99lr/raft that referenced this pull request May 10, 2024
- Link to `nvtx3` instead of deprecated `nvToolsExt`
- Use `LAZY` cmake install message, to avoid flooding the console with all the headers name when they are left untouched.

Authors:
  - Micka (https://github.com/lowener)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: rapidsai#2246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants