Re enable IVF random sampling #2225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7edd372. Subsampling is implemented in a separate PR, therefore the reletad code was removed while reverting.
tfeher
added
improvement
|
Note this will only compile once #2155 is merged. |
…vf_random_sampling
achirkin
approved these changes
Mar 19, 2024
cjnolet
requested changes
Apr 22, 2024
| * PER_CLUSTER. In both cases, we will use `pq_book_size * max_train_points_per_pq_code` training | ||
| * points to train each codebook. | ||
| */ | ||
| uint32_t max_train_points_per_pq_code = 256; |
There was a problem hiding this comment.
Why 256 here? Have we tested this empirically across many datasets ti verify this is a good default?
There was a problem hiding this comment.
The default value is inspired by FAISS, which also has 256 as default. We tested on DEEP-100M here #2052 (comment). I will share results on other datasets.
tfeher
commented
May 15, 2024
| * PER_CLUSTER. In both cases, we will use `pq_book_size * max_train_points_per_pq_code` training | ||
| * points to train each codebook. | ||
| */ | ||
| uint32_t max_train_points_per_pq_code = 256; |
There was a problem hiding this comment.
The default value is inspired by FAISS, which also has 256 as default. We tested on DEEP-100M here #2052 (comment). I will share results on other datasets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random sampling of training set for IVF methods was reverted in #2144 due to the large memory usage of the subsample method.
PR #2155 implements a new random sampling method. Using that we can now enable random sampling of IVF methods (#2052 and #2077), therefore this PR reverts #2144, and adjust the code to utilize the new sampling method.