-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve RBC eps-neighborhood query performance #2211
Improve RBC eps-neighborhood query performance #2211
Conversation
cpp/include/raft/spatial/knn/detail/ball_cover/registers-inl.cuh
Outdated
Show resolved
Hide resolved
cpp/include/raft/spatial/knn/detail/ball_cover/registers-inl.cuh
Outdated
Show resolved
Hide resolved
cpp/include/raft/spatial/knn/detail/ball_cover/registers-inl.cuh
Outdated
Show resolved
Hide resolved
Thanks @Nyrio for the review. i have added a couple of minor updates that slightly improve perf further. Still could not find a way to remove the latency issue of the distance-compute-loads though. I have not applied the changes to all kernel variants yet until we decide to settle on it. |
cpp/include/raft/spatial/knn/detail/ball_cover/registers-inl.cuh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Malte for the PR, it is great to have a large speedup for the eps-neighborhood kernels. Overall the PR looks good to me.
Please add a few more details about the optimizations into the description, eg:
- pruning of points within selected landmark neighborhood using triangle inequality
- specialized 2D and 3D kernels
Many thanks to @Nyrio for helping with the optimizations and the review!
cpp/include/raft/spatial/knn/detail/ball_cover/registers-inl.cuh
Outdated
Show resolved
Hide resolved
/merge |
This PR significantly improves performance of epsilon neighborhood search via RBC.
Scope:
Optimizations include:
CC @cjnolet , @tfeher