Automate C++ include file grouping and ordering using clang-format #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
improvement
github-actions
bot
added
cpp
and removed
improvement
harrism
changed the title
harrism
added
improvement
|
ignore commit message on Undo temporary removal of long-running test, it should just be a merge commit, but vscode had a different message in the edit box. |
cjnolet
approved these changes
Feb 28, 2024
|
/merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: currently cpp/test/neighbors/ann_ivf_pq/test_float_uint32_t.cu is commented out to initially save CI time (this file takes a long time to build). Once CI is passing once I will uncomment it.
Description
This uses the IncludeCategories settings in .clang-format to automate include ordering and grouping and to make include ordering more consistent with the rest of RAPIDS. For discussion, see rapidsai/cudf#15063. This PR uses a similar set of header grouping categories used in that PR, adapted for RAFT.
The header reordering in this PR uncovered one place where
#include <cutlass/layout/pitch_linear.h>was missing fromraft/cpp/include/raft/distance/detail/./pairwise_distance_epilogue_elementwise.h, so I also added that include.One purpose of this is to make it easier to automate injection of a header change with an upcoming RMM refactoring (and in the future).
Closes #2193