Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11, require NumPy 1.23+ #2200

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Feb 26, 2024

Description

Contributes to rapidsai/build-planning#3

This PR adds support for Python 3.11.

It also bumps uses of NumPy to numpy>=1.23, see rapidsai/build-planning#3 (comment).

Notes for Reviewers

This is part of ongoing work to add Python 3.11 support across RAPIDS.

The Python 3.11 CI workflows introduced in rapidsai/shared-workflows#176 are optional... they are not yet required to run successfully for PRs to be merged.

This PR can be merged once all jobs are running successfully (including the non-required jobs for Python 3.11). The CI logs should be verified that the jobs are building and testing with Python 3.11.

See rapidsai/shared-workflows#176 for more details.

@jameslamb jameslamb added 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 26, 2024
@jameslamb jameslamb removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Feb 27, 2024
@jameslamb jameslamb marked this pull request as ready for review February 27, 2024 16:30
@jameslamb jameslamb requested review from a team as code owners February 27, 2024 16:30
@jakirkham
Copy link
Member

Since Python 3.11 requires NumPy 1.23 at a minimum ( rapidsai/cucim#704 (comment) ), should we update lines like this one?

- &numpy numpy>=1.21

@jameslamb jameslamb changed the title Add support for Python 3.11 Add support for Python 3.11, require NumPy 1.23+ Feb 28, 2024
@bdice
Copy link
Contributor

bdice commented Feb 29, 2024

/merge

@rapids-bot rapids-bot bot merged commit ad27a73 into rapidsai:branch-24.04 Feb 29, 2024
73 checks passed
@cjnolet
Copy link
Member

cjnolet commented Feb 29, 2024

/merge

@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

6 participants