Fixing workaroun to cuSPARSE bug that was reverted during 24.02 release #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake sure we fail until there's a better fix
Co-authored-by: Bradley Dice <[email protected]>
…to bug-cuda122-cusparse-bug
cjnolet
added
bug
ChuckHastings
approved these changes
Feb 14, 2024
trxcllnt
reviewed
Feb 14, 2024
trxcllnt
reviewed
Feb 14, 2024
Co-authored-by: Paul Taylor <[email protected]>
trxcllnt
reviewed
Feb 14, 2024
| // and incorrect results. This bug is fixed in CUDA 12.5+ so this workaround shouldn't be removed | ||
| // until that version is supported. | ||
| auto z_tmp = raft::make_device_matrix<ValueType, IndexType>(handle, z.extent(0), z.extent(1)); | ||
| raft::copy(z_tmp.data_handle(), z.data_handle(), z.size(), raft::resource::get_cuda_stream(handle)); |
There was a problem hiding this comment.
Fixes style checker:
Suggested change
| raft::copy(z_tmp.data_handle(), z.data_handle(), z.size(), raft::resource::get_cuda_stream(handle)); | |
| raft::copy( | |
| z_tmp.data_handle(), z.data_handle(), z.size(), raft::resource::get_cuda_stream(handle)); | |
There was a problem hiding this comment.
@mfoerste4's PR 2185 uses an intermediate device_uvector instead of a raft::device_matrix because the matrix's size() isn't suitable for the copy here.
That PR is targeting branch-24.02. Should we merge that PR into 24.02 and rerelease RAFT, or should we merge that PR into this one and include it in 24.04?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround was accidentally reverted during this commit but the additional memory copy is needed for proper results in CUDA 12.2-12.4.