Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix is_row/col_order for strided layouts #2173

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix is_row/col_order for strided layouts #2173

merged 1 commit into from
Feb 12, 2024

Conversation

mfoerste4
Copy link
Collaborator

Add additional constraint to is_row/col_major check.

@mfoerste4 mfoerste4 requested a review from a team as a code owner February 12, 2024 11:29
@github-actions github-actions bot added the cpp label Feb 12, 2024
tfeher
tfeher approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tfeher tfeher added bug Something isn't working non-breaking Non-breaking change labels Feb 12, 2024
@raydouglass raydouglass merged commit dc75590 into rapidsai:branch-24.02 Feb 12, 2024
60 of 61 checks passed
@bdice bdice mentioned this pull request Feb 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfoerste4 @tfeher @raydouglass