Pin to pytest 7. #2137
Merged
Pin to pytest 7. #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
approved these changes
Jan 31, 2024
cjnolet
approved these changes
Jan 31, 2024
raydouglass
approved these changes
Jan 31, 2024
rapids-bot bot
pushed a commit
that referenced
this pull request
May 8, 2024
This PR fixes the underlying issue that led us to pin pytest in #2137. For now, this PR leaves pytest pinned since there are other issues with pytest 8 and plugin interactions that have broken other RAPIDS libraries so I figured this was safer and we could relax the pin when the rest of RAPIDS does. However, if preferred I'm happy to undo the pinning in this PR too. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Ray Douglass (https://github.com/raydouglass) URL: #2142
abc99lr
pushed a commit
to abc99lr/raft
that referenced
this pull request
May 10, 2024
This PR fixes the underlying issue that led us to pin pytest in rapidsai#2137. For now, this PR leaves pytest pinned since there are other issues with pytest 8 and plugin interactions that have broken other RAPIDS libraries so I figured this was safer and we could relax the pin when the rest of RAPIDS does. However, if preferred I'm happy to undo the pinning in this PR too. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#2142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an unusual test failure in raft-dask:
The tests started failing at the same time that pytest 8 was released. This PR tests with
pytest==7.*to isolate the root cause (and fix it if it is the problem).