Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix num_cta_per_query div #2107

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Jan 22, 2024

This bug happened when trying to run a CAGRA index with itopk=100 and topk=100. The num_cta_per_query variable was equal to 3 because 100 / 32 = 3.125 instead of ceildiv(100, 32) = 4. This resulted in the following error:

RuntimeError: RAFT failure at file=/opt/conda/conda-bld/work/cpp/include/raft/neighbors/detail/cagra/search_multi_cta.cuh line=183:
`num_cta_per_query` (3) * 32 must be equal to or greater than `topk` (100) when 'search_mode' is "multi-cta". (`num_cta_per_query`=max(`search_width`, `itopk_size`/32))

Signed-off-by: Mickael Ide <[email protected]>
@lowener lowener requested a review from a team as a code owner January 22, 2024 18:12
@github-actions github-actions bot added the cpp label Jan 22, 2024
@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Jan 22, 2024
@enp1s0 enp1s0 self-requested a review January 23, 2024 14:51
Copy link
Member

@enp1s0 enp1s0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lowener, for fixing the bug! The PR looks good to me.

@cjnolet
Copy link
Member

cjnolet commented Jan 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit d89ab1b into rapidsai:branch-24.02 Jan 23, 2024
61 checks passed
@lowener lowener deleted the 24.02-cagra-itopkdiv branch January 24, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants