-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CUDA 12.2 #2092
Support CUDA 12.2 #2092
Conversation
https://github.com/rapidsai/raft/actions/runs/7494925981/job/20403970360?pr=2092#step:7:644
I suspect this is causing issues due to buggy install rules which we've patched in rapids-cmake but aren't present in the CUDA 12.2 local copy that this build is finding. We probably need to do something to prevent RAPIDS from using the CUDA 12.2 CCCL version 2.2.0, since it doesn't have the CMake patches we need. Always downloading is the only solution I can think of, unless there's a safe way for us to force patching a local package. I think this probably needs something like |
It looks like force-downloading CCCL has fixed the build here. I opened a rapids-cmake PR to always download CCCL: rapidsai/rapids-cmake#522 |
The diagnosis is right. I'm not sure of the fix though. I'll comment on the rapids-cmake PR. |
While working on #2102, I noticed an issue. In the We will also need to ignore the strong run export of I'm not sure if we want to treat this as a CUDA packaging bug or as a bug in libraft's recipe (it applies to all of RAPIDS). We had discussed "assuming CUDA Enhanced Compatibility by default" and considered the possibility of loosening the CUDA compiler pin to |
Looks like this is now green! 🥳 |
One of the jobs failed due to |
All CI is passing and CI logs look good. We need an ops review from @AyodeAwe / @raydouglass to proceed. I'll trigger the |
/merge |
Follow-up to #2092 For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows` with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged. ### Notes for Reviewers This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS. For more details see: * rapidsai/build-planning#7 *(created with `rapids-reviser`)* Authors: - James Lamb (https://github.com/jameslamb) - https://github.com/jakirkham Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #2189
Description
Notes for Reviewers
This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS.
For more details see:
Planning a second round of PRs to revert these references back to a proper
branch-24.{nn}
release branch ofshared-workflows
once rapidsai/shared-workflows#166 is merged.I intentionally did not add a CUDA 12.2 environment for ANN benchmarks, as I assumed that would be more involved and because it isn't strictly necessary to support building and publishing packages that support CUDA 12.2.
raft/dependencies.yaml
Lines 23 to 26 in 93a504e
(created with
rapids-reviser
)