-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Sparse semiring cleanup + hash table and batching strategies #207
[WIP] Sparse semiring cleanup + hash table and batching strategies #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review looks good to me (excepting strategies part which I will clean up soon)! Only one comment and one question - the tests for the new distances remain to be added, right?
@dantegd, I've updated this PR for branch 21.06 but I'm not familiar with the new package management. I'm getting the following build error, though I do see cuco in the build directory. Is there something we need to add to the gtest build?
|
Just marking this here so I don't forget- It looks like the current cuco API is slightly different than it was when the
These are the obvious errors I see at the top of the trace. I'm hoping fixing these might fix everything else? I'm not sure yet, but I think maybe we should push this change to 21.08. |
Closing this as it's replaced by #269 |
This PR is intended to be merged after #207 (hash table strategy) has been merged. This PR introduces the following distances: - Hamming - Jensen-Shannon - Russell-Rao - KL-Divergence - Correlation Most of the changes here are from #207 and will be reviewed in that PR. The only files that need to be reviewed for this PR are `sparse/distance/l2_distance.cuh`, `sparse/distance/bin_distance.cuh`, `sparse/distance/lp_distances.cuh`, and their corresponding gtests: `test/sparse/distance.cuh` Authors: - Corey J. Nolet (https://github.com/cjnolet) - Divye Gala (https://github.com/divyegala) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #261
Some minor fixes that are required to publish our rust bindings to crates.io: * using relative paths in the cuvs-sys cmake files didn't work, get around this by symlinking required files instead * Need to specify an actual version for cuvs-sys and ndarray-rand packages in the rust/cuvs/Cargo.toml file Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai/cuvs#207
This branch includes several new features and optimizations:
distances_config_t
rather than accepting each resource explicitlyThis PR is also required to merge #261, which introduces the remaining distances