Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark brute force knn #2063

Merged
merged 12 commits into from
Dec 20, 2023
Merged

Benchmark brute force knn #2063

merged 12 commits into from
Dec 20, 2023

Conversation

benfred
Copy link
Member

@benfred benfred commented Dec 13, 2023

Add our bfknn code to the raft-ann-bench project

@benfred
Benchmark brute force knn
49970f4 
Add our bfknn code to the raft-ann-bench project
@benfred benfred requested review from a team as code owners December 13, 2023 20:47
@benfred benfred added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 13, 2023
@benfred benfred requested a review from a team as a code owner December 13, 2023 21:35
cjnolet
cjnolet requested changes Dec 15, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think it just needs a static assertion so we can throw an error if an unsupported data type is used.

@benfred benfred requested a review from cjnolet December 19, 2023 22:19
@benfred
Copy link
Member Author

benfred commented Dec 19, 2023

Looks good, I think it just needs a static assertion so we can throw an error if an unsupported data type is used.

@cjnolet I added the static assert here f71f657

@benfred
Copy link
Member Author

benfred commented Dec 20, 2023

/merge

@rapids-bot rapids-bot bot merged commit 7e098b2 into rapidsai:branch-24.02 Dec 20, 2023
61 checks passed
ChristinaZ pushed a commit to ChristinaZ/raft that referenced this pull request Jan 17, 2024
@benfred @ChristinaZ
Benchmark brute force knn (rapidsai#2063)
16e0193 
Add our bfknn code to the raft-ann-bench project

Authors:
  - Ben Frederickson (https://github.com/benfred)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#2063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@benfred benfred

Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benfred @cjnolet