Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raft-ann-bench output filenames and add features to plotting #2043

Merged
merged 8 commits into from
Dec 21, 2023

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Dec 6, 2023

This PR:

  1. Adds more clarity to filenames by using , as separator instead of _
  2. Adds 80% and 99% recall bars to build plots
  3. Does not plot a recall level in build plot if no data is present
  4. Adds a x-start argument which allows controlling the minimum recall level used on the x-axis of the search plot
  5. Fixes sometimes occurring multi-line issue in search plots
  6. Build time plots now plot average build times for an index corresponding a search query in each recall range

@divyegala divyegala added feature request New feature or request breaking Breaking change labels Dec 6, 2023
@divyegala divyegala self-assigned this Dec 6, 2023
@divyegala divyegala requested a review from a team as a code owner December 6, 2023 02:30
@github-actions github-actions bot added the python label Dec 6, 2023
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Just need to update the recall windows and this is ready.

@cjnolet
Copy link
Member

cjnolet commented Dec 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit bae049b into rapidsai:branch-24.02 Dec 21, 2023
61 checks passed
ChristinaZ pushed a commit to ChristinaZ/raft that referenced this pull request Jan 17, 2024
…rapidsai#2043)

This PR:
1. Adds more clarity to filenames by using `,` as separator instead of `_`
2. Adds 80% and 99% recall bars to build plots
3. Does not plot a recall level in build plot if no data is present
4. Adds a `x-start` argument which allows controlling the minimum recall level used on the x-axis of the search plot
5. Fixes sometimes occurring multi-line issue in search plots
6. Build time plots now plot average build times for an index corresponding a search query in each recall range

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#2043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change feature request New feature or request python
Projects
Development

Successfully merging this pull request may close these issues.

2 participants