-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Pareto frontier in raft-ann-bench.data_export
#2009
Merged
rapids-bot
merged 9 commits into
rapidsai:branch-24.02
from
divyegala:data-export_pareto-frontier
Nov 18, 2023
Merged
Export Pareto frontier in raft-ann-bench.data_export
#2009
rapids-bot
merged 9 commits into
rapidsai:branch-24.02
from
divyegala:data-export_pareto-frontier
Nov 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
added
feature request
New feature or request
non-breaking
Non-breaking change
labels
Nov 17, 2023
cjnolet
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I know you are adding the guard for the read_file but pre-approving.
/ok to test |
/ok to test |
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR now exports 3 CSVs from search result JSON files of the suffixes:
raw
: All resultsthroughput
: Pareto frontier of throughput resultslatency
: Pareto frontier of latency resultsThe Pareto frontier is now no more created in
raft-ann-bench.plot
.