Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Pareto frontier in raft-ann-bench.data_export #2009

Merged

Conversation

divyegala
Copy link
Member

This PR now exports 3 CSVs from search result JSON files of the suffixes:

  1. raw: All results
  2. throughput: Pareto frontier of throughput results
  3. latency: Pareto frontier of latency results

The Pareto frontier is now no more created in raft-ann-bench.plot.

@divyegala divyegala added feature request New feature or request non-breaking Non-breaking change labels Nov 17, 2023
@divyegala divyegala self-assigned this Nov 17, 2023
@divyegala divyegala requested review from a team as code owners November 17, 2023 02:42
@divyegala divyegala changed the base branch from branch-23.12 to branch-24.02 November 17, 2023 02:42
@divyegala divyegala removed request for a team November 17, 2023 02:42
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I know you are adding the guard for the read_file but pre-approving.

Copy link

copy-pr-bot bot commented Nov 17, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@divyegala
Copy link
Member Author

/ok to test

@divyegala
Copy link
Member Author

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Nov 18, 2023

/merge

@rapids-bot rapids-bot bot merged commit bdc5117 into rapidsai:branch-24.02 Nov 18, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

2 participants