-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ANN bench scripts to generate ground truth #1967
Add ANN bench scripts to generate ground truth #1967
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be very useful to have in the raft-ann-bench code, thanks for adding! Hopefully soon we will also be able to provide a means for users to convert their own datasets into the proper binary format to be loaded by raft-Ann-bench also.
python/raft-ann-bench/src/raft-ann-bench/scripts/generate_groundtruth.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/scripts/generate_groundtruth.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/scripts/generate_groundtruth.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/scripts/generate_groundtruth.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/scripts/generate_groundtruth.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/scripts/generate_groundtruth.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Corey for the review, I have updated the PR accordingly.
python/raft-ann-bench/src/raft-ann-bench/scripts/generate_groundtruth.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/scripts/generate_groundtruth.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/scripts/generate_groundtruth.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/scripts/generate_groundtruth.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/scripts/generate_groundtruth.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/generate_groundtruth/__main__.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/generate_groundtruth/utils.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/generate_groundtruth/utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cjnolet for the second review, fixed the issues.
python/raft-ann-bench/src/raft-ann-bench/generate_groundtruth/__main__.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/generate_groundtruth/utils.py
Outdated
Show resolved
Hide resolved
python/raft-ann-bench/src/raft-ann-bench/generate_groundtruth/utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/merge |
Add a command line based tool that can read a dataset and generate ground truth files with exact neighbors using raft brute force knn. Authors: - Tamas Bela Feher (https://github.com/tfeher) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#1967
Add a command line based tool that can read a dataset and generate ground truth files with exact neighbors using raft brute force knn.