Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused header #1960

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Nov 4, 2023

Including the header can cause compilation issues under certain conditions when an implicit dependency on TBB is brought in. This header was unused anyway, so it has been removed.

Including the <execution> header can cause compilation issues under certain conditions when an implicit dependency on TBB is brought in. This header was unused anyway, so it has been removed.
@wphicks wphicks requested a review from a team as a code owner November 4, 2023 02:39
Copy link

copy-pr-bot bot commented Nov 4, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the cpp label Nov 4, 2023
@benfred
Copy link
Member

benfred commented Nov 4, 2023

/ok to test

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 4, 2023
@cjnolet
Copy link
Member

cjnolet commented Nov 4, 2023

/merge

@rapids-bot rapids-bot bot merged commit aa3e229 into rapidsai:branch-23.12 Nov 4, 2023
57 checks passed
benfred pushed a commit to benfred/raft that referenced this pull request Nov 8, 2023
Including the <execution> header can cause compilation issues under certain conditions when an implicit dependency on TBB is brought in. This header was unused anyway, so it has been removed.

Authors:
  - William Hicks (https://github.com/wphicks)

Approvers:
  - Ben Frederickson (https://github.com/benfred)

URL: rapidsai#1960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants