CAGRA ANN bench: parse build options for IVF-PQ build algo #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfeher
added
improvement
tfeher
commented
Oct 18, 2023
cjnolet
reviewed
Nov 6, 2023
python/raft-ann-bench/src/raft-ann-bench/run/conf/wiki_all.json
Outdated
Show resolved
Hide resolved
cjnolet
reviewed
Nov 6, 2023
tfeher
commented
Nov 7, 2023
python/raft-ann-bench/src/raft-ann-bench/run/conf/wiki_all_1M.json
Outdated
Show resolved
Hide resolved
|
/merge |
benfred
pushed a commit
to benfred/raft
that referenced
this pull request
Nov 8, 2023
…1912) This PR enables fine tuning the the parameters for CAGRA index building using the IVF-PQ build algo. This is only affects ANN bechmarks (an example json file is added). The public API of CAGRA is not changed because: - Advanced users can achieve the same effect by calling `build_knn_graph` and `optimize` individually. - Long term we consider NN descent to be the preferred build algo, which does not need IVF-PQ parameters. Authors: - Tamas Bela Feher (https://github.com/tfeher) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#1912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables fine tuning the the parameters for CAGRA index building using the IVF-PQ build algo.
This is only affects ANN bechmarks (an example json file is added). The public API of CAGRA is not changed because:
build_knn_graphandoptimizeindividually.