Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Googletests and re-enabling in CI #1904

Merged
merged 20 commits into from
Oct 19, 2023
Merged

Fixing Googletests and re-enabling in CI #1904

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4de33d0
Reverting ci logic to run gtests.
cjnolet Oct 16, 2023
1dd0f9d
Remove clamping from fused l2 nn
cjnolet Oct 16, 2023
4ca9c0d
Trying again
cjnolet Oct 16, 2023
d90c09e
Changing digits
cjnolet Oct 16, 2023
7edff32
cd into libraft test dir
cjnolet Oct 16, 2023
8afb99f
Fixing ctest
cjnolet Oct 16, 2023
cc6aaaa
Fix clamping to "true" positives
cjnolet Oct 17, 2023
3ec6dcc
Another fix
cjnolet Oct 17, 2023
18743cc
Fixing numerical error from self-looping
cjnolet Oct 17, 2023
f52765f
Removing print
cjnolet Oct 17, 2023
7d53e0d
Still root causing the fused l2 nn issue
cjnolet Oct 18, 2023
be98652
Pytests are passing again
cjnolet Oct 18, 2023
1222520
Making the change everywhere
cjnolet Oct 18, 2023
71f09c7
Merge remote-tracking branch 'origin/branch-23.12' into build-2312-fi…
cjnolet Oct 18, 2023
3549ee7
Fixing round-off errors
cjnolet Oct 18, 2023
71c7d83
Squaring value to see if it helps precision
cjnolet Oct 18, 2023
0f2ec3c
Updating tiled bfknn to use standard l2_exp op
cjnolet Oct 18, 2023
06d62a3
Fixing another cagra threshold
cjnolet Oct 18, 2023
7fc4c8e
And another
cjnolet Oct 18, 2023
9263371
Cleaning tings up
cjnolet Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/test_cpp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ trap "EXITCODE=1" ERR
set +e

# Run libraft gtests from libraft-tests package
cd "$CONDA_PREFIX"/bin/gtests/libraft
ctest -j8 --output-on-failure

rapids-logger "Test script exiting with value: $EXITCODE"
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/raft/distance/detail/distance_ops/l2_exp.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ struct l2_exp_cutlass_op {
// outVal could be negative due to numerical instability, especially when
// calculating self distance.
// clamp to 0 to avoid potential NaN in sqrt
outVal = outVal * (raft::abs(outVal) >= DataT(0.0001));
outVal = outVal * (raft::abs(outVal) >= DataT(1e-6));
return sqrt ? raft::sqrt(outVal) : outVal;
}

Expand Down
Loading