Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all cuda kernels have hidden visibility #1898

Conversation

robertmaynard
Copy link
Contributor

Effect on binary size of libraft.a
23.12: 133361630
pr: 129748904

Effect on binary size of libraft.so
23.12: 83603224
pr: 83873088

@robertmaynard robertmaynard added feature request New feature or request non-breaking Non-breaking change labels Oct 12, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner October 12, 2023 18:36
@github-actions github-actions bot added the cpp label Oct 12, 2023
@robertmaynard
Copy link
Contributor Author

Replaces #1723

I am working on a follow PR that will marks all kernel call sites as hidden visibility which will allow us to close #1722

@robertmaynard robertmaynard force-pushed the fea/hide_visibility_of_kernel_launches branch from e630d0f to 76b3508 Compare October 12, 2023 18:39
Effect on binary size of libraft.a

23.12: 133361630
pr: 129748904

Effect on binary size of libraft.so

23.12: 83603224
pr: 83873088
@robertmaynard robertmaynard force-pushed the fea/hide_visibility_of_kernel_launches branch from 5649047 to 1c4d149 Compare October 13, 2023 14:02
@cjnolet
Copy link
Member

cjnolet commented Oct 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit 27dcf7b into rapidsai:branch-23.12 Oct 13, 2023
59 checks passed
@robertmaynard robertmaynard deleted the fea/hide_visibility_of_kernel_launches branch October 16, 2023 20:22
divyegala pushed a commit to divyegala/raft that referenced this pull request Oct 17, 2023
Effect on binary size of libraft.a
23.12: 133361630
pr: 129748904

Effect on binary size of libraft.so
23.12: 83603224
pr: 83873088

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#1898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants