Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CAGRA auto mode selection #1830

Merged
merged 8 commits into from
Sep 26, 2023
Merged

Change CAGRA auto mode selection #1830

merged 8 commits into from
Sep 26, 2023

Conversation

enp1s0
Copy link
Member

@enp1s0 enp1s0 commented Sep 18, 2023

This PR changes the rule to select a CAGRA search mode as written in the CAGRA paper.

@enp1s0 enp1s0 requested a review from a team as a code owner September 18, 2023 17:31
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 18, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@enp1s0 enp1s0 self-assigned this Sep 18, 2023
@github-actions github-actions bot added the cpp label Sep 18, 2023
@enp1s0 enp1s0 added improvement Improvement / enhancement to an existing function breaking Breaking change and removed cpp labels Sep 18, 2023
@cjnolet
Copy link
Member

cjnolet commented Sep 20, 2023

/ok to test

@github-actions github-actions bot added the cpp label Sep 20, 2023
@enp1s0 enp1s0 changed the title [WIP] Change CAGRA auto mode selection Change CAGRA auto mode selection Sep 20, 2023
tfeher
tfeher approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @enp1s0 for the PR, looks good to me!

@cjnolet
Copy link
Member

cjnolet commented Sep 25, 2023

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Sep 25, 2023

/merge

@cjnolet
Copy link
Member

cjnolet commented Sep 25, 2023

@enp1s0 looks like there's a failure in the tests in CI here.

@enp1s0 enp1s0 requested a review from a team as a code owner September 26, 2023 04:37
@cjnolet
Copy link
Member

cjnolet commented Sep 26, 2023

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Sep 26, 2023

/merge

@rapids-bot rapids-bot bot merged commit ed42bb5 into rapidsai:branch-23.10 Sep 26, 2023
54 checks passed
@enp1s0
Copy link
Member Author

enp1s0 commented Sep 26, 2023

Thank you for merging the PR!

@enp1s0 enp1s0 deleted the cagra-auto-mode-selection branch September 26, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@enp1s0 enp1s0

Labels
breaking Breaking change cpp improvement Improvement / enhancement to an existing function python
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enp1s0 @cjnolet @tfeher