Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix::select_k: extra tests and benchmarks #1821

Merged
merged 2 commits into from
Sep 18, 2023
Merged

matrix::select_k: extra tests and benchmarks #1821

merged 2 commits into from
Sep 18, 2023

Conversation

achirkin
Copy link
Contributor

Add a few extra test and benchmark cases; in particular:

  1. Allow specifying non-trivial input indices
  2. Allow filling the input data with infinities to see how algorithms perform in edge cases

These tests are borrowed from the controversial workaround #1742

@achirkin achirkin added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 13, 2023
@achirkin achirkin requested a review from a team as a code owner September 13, 2023 13:49
@github-actions github-actions bot added the cpp label Sep 13, 2023
tfeher
tfeher requested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Artem for improving the tests. Looks good, just two small questions.

cpp/test/matrix/select_k.cuh Show resolved Hide resolved
cpp/test/matrix/select_k.cuh Show resolved Hide resolved
tfeher
tfeher approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @achirkin for answering my questions. LGTM.

cpp/test/matrix/select_k.cuh Show resolved Hide resolved
@achirkin
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b9cf917 into rapidsai:branch-23.10 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

Assignees

@achirkin achirkin

Labels
3 - Ready for Review cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achirkin @tfeher