ANN-bench: more flexible cuda_stub.hpp #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achirkin
added
enhancement
7 tasks
cjnolet
approved these changes
Sep 2, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
cpp/bench/ann/src/common/cuda_stub.hppmore flexible and include it in all benchmarks (instead of onlyANN_BENCHtarget).This makes the targets (benchmark libs), which define
CPU_ONLY, on depend on CUDA headers, thus enabling the builds without GPU.This should relief #1773 of doing extra workarounds in the bench headers to achieve the same effect.