Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix search parameter check in CAGRA #1784

Merged
merged 5 commits into from
Aug 30, 2023
Merged

[BUG] Fix search parameter check in CAGRA #1784

merged 5 commits into from
Aug 30, 2023

Conversation

enp1s0
Copy link
Member

@enp1s0 enp1s0 commented Aug 29, 2023

An error occurs when using CAGRA multi-CTA implementation with topk>32. This PR fixes the bug.

@enp1s0 enp1s0 requested a review from a team as a code owner August 29, 2023 11:31
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 29, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the cpp label Aug 29, 2023
@enp1s0 enp1s0 self-assigned this Aug 29, 2023
@enp1s0 enp1s0 added bug Something isn't working non-breaking Non-breaking change labels Aug 29, 2023
achirkin
achirkin approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@achirkin achirkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@achirkin
Copy link
Contributor

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Aug 30, 2023

/merge

@cjnolet
Copy link
Member

cjnolet commented Aug 30, 2023

/ok to test

@rapids-bot rapids-bot bot merged commit b1f7374 into rapidsai:branch-23.10 Aug 30, 2023
@enp1s0 enp1s0 deleted the fix-CAGRA-config-check branch August 30, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@lowener lowener lowener approved these changes

@achirkin achirkin achirkin approved these changes

Assignees

@enp1s0 enp1s0

Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enp1s0 @achirkin @cjnolet @lowener @divyegala