-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding config files for remaining (relevant) ann-benchmarks million-scale datasets #1761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, one comment regarding docs clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a section in the documentation that describes how to form the configuration for an index. Could you add the new memory type key there?
Discussed offline- we're going to improve the docs for the benchmarks further by specifying each of the possible indexing, build, and search arguments in a table and further explaining each of them. |
/merge |
Also exposing new
dataset_memtype
option for the RAFT index types that allows us to specify (in the config files) for each index whether we want the dataset to be fed in from "host", "device" or "mmap" (host memory-mapped).