Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding config files for remaining (relevant) ann-benchmarks million-scale datasets #1761

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Aug 22, 2023

Also exposing new dataset_memtype option for the RAFT index types that allows us to specify (in the config files) for each index whether we want the dataset to be fed in from "host", "device" or "mmap" (host memory-mapped).

@cjnolet cjnolet added feature request New feature or request non-breaking Non-breaking change labels Aug 22, 2023
@cjnolet cjnolet self-assigned this Aug 22, 2023
@cjnolet cjnolet requested a review from divyegala August 22, 2023 22:26
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, one comment regarding docs clarity

@cjnolet cjnolet requested a review from a team as a code owner August 24, 2023 03:25
@github-actions github-actions bot added the cpp label Aug 24, 2023
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a section in the documentation that describes how to form the configuration for an index. Could you add the new memory type key there?

@cjnolet
Copy link
Member Author

cjnolet commented Aug 24, 2023

Discussed offline- we're going to improve the docs for the benchmarks further by specifying each of the possible indexing, build, and search arguments in a table and further explaining each of them.

@cjnolet
Copy link
Member Author

cjnolet commented Aug 24, 2023

/merge

@rapids-bot rapids-bot bot merged commit 08a1fad into rapidsai:branch-23.10 Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp feature request New feature or request non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

2 participants