Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ann-bench Documentation #1754

Merged
merged 8 commits into from
Aug 22, 2023
Merged

Fix ann-bench Documentation #1754

merged 8 commits into from
Aug 22, 2023

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Aug 18, 2023 •
edited
Loading

  • In run.py instead of hard-coding base.fbin and query.fbin, let conf files specify the filenames
  • In data_export.py instead of requiring <result_filepaths>, the script checks <dataset_path/result automatically

@divyegala divyegala added bug Something isn't working non-breaking Non-breaking change labels Aug 18, 2023
@divyegala divyegala self-assigned this Aug 18, 2023
@cjnolet
Copy link
Member

cjnolet commented Aug 22, 2023

Waiting on readme updates before merge (we probably should have made those updates when we moved everything into bench/ann)

@divyegala
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 264cb65 into rapidsai:branch-23.10 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@divyegala divyegala

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divyegala @cjnolet