Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build.sh to enable NEIGHBORS_ANN_CAGRA_TEST #1724

Merged

Conversation

enp1s0
Copy link
Member

@enp1s0 enp1s0 commented Aug 8, 2023

This PR update build.sh to enable NEIGHBORS_ANN_CAGRA_TEST.

@enp1s0 enp1s0 requested a review from a team as a code owner August 8, 2023 05:45
@enp1s0 enp1s0 self-assigned this Aug 8, 2023
@enp1s0 enp1s0 added bug Something isn't working non-breaking Non-breaking change labels Aug 8, 2023
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake approval.

build.sh Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a couple small things after approving, requesting changes for that.

build.sh Outdated Show resolved Hide resolved
enp1s0 and others added 4 commits August 9, 2023 09:30
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
@enp1s0
Copy link
Member Author

enp1s0 commented Aug 9, 2023

Thanks @bdice for reviewing the changes. I have fixed the issues.

@cjnolet
Copy link
Member

cjnolet commented Aug 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit bc8850a into rapidsai:branch-23.10 Aug 10, 2023
@enp1s0 enp1s0 deleted the fix-buildsh-to-enable-CAGRA-test branch August 10, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants