Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bench-ann configuration #1696

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Jul 31, 2023

  • Update algorithms names to reflect scripts/ann-benchmarks/algos.yaml : [raft_ivf_flat, raft_ivf_pq, raft_cagra].
  • Add -f short argument to our script to be consistent with C++ error message asking for -f flag
    log_error("'%s' already exists, use '-f' to force overwriting", file.c_str());
  • Build raft_cagra only once and run the three different algorithms on it, instead of building 3 time the same cagra index.

@lowener lowener requested a review from a team as a code owner July 31, 2023 15:25
@github-actions github-actions bot added the cpp label Jul 31, 2023
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 31, 2023
@cjnolet
Copy link
Member

cjnolet commented Aug 2, 2023

/merge

@rapids-bot rapids-bot bot merged commit a85c5c7 into rapidsai:branch-23.10 Aug 2, 2023
@lowener lowener deleted the 23.08-bench branch August 2, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

2 participants