-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix template types for create_descriptor function. #1680
Merged
rapids-bot
merged 8 commits into
rapidsai:branch-23.10
from
csadorf:fix-create-cusparse-descriptor-types
Aug 10, 2023
Merged
Fix template types for create_descriptor function. #1680
rapids-bot
merged 8 commits into
rapidsai:branch-23.10
from
csadorf:fix-create-cusparse-descriptor-types
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
bug
Something isn't working
and removed
improvement
Improvement / enhancement to an existing function
labels
Jul 26, 2023
Similar to the calling functions.
…cusparse-descriptor-types
csadorf
changed the title
[WIP] Fix template types for create_descriptor function.
Fix template types for create_descriptor function.
Aug 1, 2023
@csadorf is this one ready to be merged? |
Yes, it is. Should I switch the target branch to 23.10 ? |
cjnolet
approved these changes
Aug 10, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use correct types for indices pointers and indices when creating the cusparse
descriptor from a device_csr_matrix_view.