Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template types for create_descriptor function. #1680

Merged

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Jul 26, 2023

Use correct types for indices pointers and indices when creating the cusparse
descriptor from a device_csr_matrix_view.

@github-actions github-actions bot added the cpp label Jul 26, 2023
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change bug Something isn't working and removed improvement Improvement / enhancement to an existing function labels Jul 26, 2023
@csadorf csadorf marked this pull request as ready for review August 1, 2023 00:14
@csadorf csadorf requested a review from a team as a code owner August 1, 2023 00:14
@csadorf csadorf changed the title [WIP] Fix template types for create_descriptor function. Fix template types for create_descriptor function. Aug 1, 2023
@cjnolet
Copy link
Member

cjnolet commented Aug 2, 2023

@csadorf is this one ready to be merged?

@csadorf
Copy link
Contributor Author

csadorf commented Aug 2, 2023

@csadorf is this one ready to be merged?

Yes, it is. Should I switch the target branch to 23.10 ?

@csadorf csadorf changed the base branch from branch-23.08 to branch-23.10 August 3, 2023 14:29
@cjnolet
Copy link
Member

cjnolet commented Aug 10, 2023

/merge

@rapids-bot rapids-bot bot merged commit b7d2a9a into rapidsai:branch-23.10 Aug 10, 2023
@csadorf csadorf deleted the fix-create-cusparse-descriptor-types branch August 10, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

2 participants