Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming namespaces to promote CAGRA from experimental #1666

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Renaming namespaces to promote CAGRA from experimental #1666

merged 4 commits into from
Jul 24, 2023

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jul 24, 2023

This PR formally renames the namespaces to promote CAGRA from experimental. It's a lot of very small changes but the approach was the following:

  1. Rename all occurrences of raft::neighbors::experimental::cagra to raft::neighbors::cagra
  2. Create new namespaces in each of the public API headers for CAGRA that export raft::neighbors::cagra to raft::neighbors::experimental::cagra
  3. Create an issue to eventually remove the deprecated raft::neighbors::experimental::cagra namespace
  4. Reference issue in TODO comments in the corresponding files to remove the experimental namespaces after a couple releases.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 24, 2023
@cjnolet cjnolet self-assigned this Jul 24, 2023
@cjnolet cjnolet requested a review from a team as a code owner July 24, 2023 17:22
@github-actions github-actions bot added the cpp label Jul 24, 2023
@cjnolet cjnolet mentioned this pull request Jul 24, 2023
Open
@cjnolet cjnolet requested a review from a team as a code owner July 24, 2023 17:36
bdice
bdice approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes look fine.

tfeher
tfeher approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thansk @cjnolet for the PR, LGTM!

@cjnolet
Copy link
Member Author

cjnolet commented Jul 24, 2023

/merge

@rapids-bot rapids-bot bot merged commit 202385b into rapidsai:branch-23.08 Jul 24, 2023
@cjnolet cjnolet mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@tfeher tfeher tfeher approved these changes

Assignees

@cjnolet cjnolet

Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjnolet @tfeher @bdice