Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: wrong constant in IVF-PQ fp_8bit2half #1654

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Hotfix: wrong constant in IVF-PQ fp_8bit2half #1654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/include/raft/neighbors/detail/ivf_pq_fp_8bit.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ struct fp_8bit {
u &= ~1; // zero the sign bit
}
half r;
constexpr uint16_t kBase16 = (0x7c00u | (0x0200u >> ValBits)) - (ExpMask << 10);
constexpr uint16_t kBase16 = (0x3c00u | (0x0200u >> ValBits)) - (ExpMask << 10);
*reinterpret_cast<uint16_t*>(&r) = kBase16 + (u << (2u + ExpBits));
if constexpr (Signed) { // recover the sign bit
if (v.bitstring & 1) { r = -r; }
Expand Down