Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR adds support to __half and nb_bfloat16 to myAtomicReduce #1585

Merged
merged 3 commits into from
Jun 10, 2023
Merged

This PR adds support to __half and nb_bfloat16 to myAtomicReduce #1585

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c8e021
This PR adds support to __half and nb_bfloat16 to myAtomicReduce
Kh4ster Jun 9, 2023
3dab532
add formating
Kh4ster Jun 9, 2023
1cfcd90
fix unsupported arch issue
Kh4ster Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions cpp/include/raft/util/cuda_utils.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@
#include <stdint.h>
#include <type_traits>

#if defined(_RAFT_HAS_CUDA)
#include <cuda_bf16.h>
#include <cuda_fp16.h>
#endif

#include <raft/core/cudart_utils.hpp>
#include <raft/core/math.hpp>
#include <raft/core/operators.hpp>
Expand Down Expand Up @@ -79,6 +84,35 @@ DI void myAtomicReduce(float* address, float val, ReduceLambda op)
} while (assumed != old);
}

// Needed for atomicCas on ushort
#if defined(__CUDA_ARCH__) && (__CUDA_ARCH__ >= 700)
template <typename ReduceLambda>
DI void myAtomicReduce(__half* address, __half val, ReduceLambda op)
{
unsigned short int* address_as_uint = (unsigned short int*)address;
unsigned short int old = *address_as_uint, assumed;
do {
assumed = old;
old = atomicCAS(address_as_uint, assumed, __half_as_ushort(op(val, __ushort_as_half(assumed))));
} while (assumed != old);
}
#endif

// Needed for nv_bfloat16 support
#if defined(__CUDA_ARCH__) && (__CUDA_ARCH__ >= 800)
template <typename ReduceLambda>
DI void myAtomicReduce(nv_bfloat16* address, nv_bfloat16 val, ReduceLambda op)
{
unsigned short int* address_as_uint = (unsigned short int*)address;
unsigned short int old = *address_as_uint, assumed;
do {
assumed = old;
old = atomicCAS(
address_as_uint, assumed, __bfloat16_as_ushort(op(val, __ushort_as_bfloat16(assumed))));
} while (assumed != old);
}
#endif

template <typename ReduceLambda>
DI void myAtomicReduce(int* address, int val, ReduceLambda op)
{
Expand Down