Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivf-flat: fix incorrect recomputed size of the index #1525

Merged
merged 2 commits into from
May 19, 2023
Merged

ivf-flat: fix incorrect recomputed size of the index #1525

merged 2 commits into from
May 19, 2023

Conversation

achirkin
Copy link
Contributor

Fix ivf-flat's recompute_internal_state incorrectly using the amortized list sizes to compute the index size.

@achirkin achirkin added bug Something isn't working non-breaking Non-breaking change labels May 18, 2023
@achirkin achirkin requested a review from tfeher May 18, 2023 07:36
@achirkin achirkin requested a review from a team as a code owner May 18, 2023 07:36
@github-actions github-actions bot added the cpp label May 18, 2023
@enp1s0
Copy link
Member

enp1s0 commented May 19, 2023

Hi @achirkin, the error in cpp-tests (TiledKNNTest) was caused by the issue mentioned in #1526 . It has been fixed now, so please merge the latest branch-23.06 commits. Thanks!

@cjnolet
Copy link
Member

cjnolet commented May 19, 2023

/merge

@rapids-bot rapids-bot bot merged commit dfb3d2c into rapidsai:branch-23.06 May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@tfeher tfeher Awaiting requested review from tfeher

Assignees

@achirkin achirkin

Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achirkin @enp1s0 @cjnolet