-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python API for IVF-Flat serialization #1516
Merged
rapids-bot
merged 9 commits into
rapidsai:branch-23.06
from
tfeher:fea_ivf_flat_serialize
May 19, 2023
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
af12034
Python API for IVF-Flat serialization
tfeher 31187c3
Fix issues
tfeher eef5918
Merge branch 'branch-23.06' into fea_ivf_flat_serialize
tfeher 7e2c67a
Set active_index_type after loading & remove device_resources
tfeher 859e6f2
fix style
tfeher 76a8920
Merge branch 'branch-23.06' into fea_ivf_flat_serialize
tfeher cbcbadd
Save dtype before index string
tfeher acf589b
Save dtype string by the C++ serializer
tfeher b1410a6
Merge branch 'branch-23.06' into fea_ivf_flat_serialize
tfeher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/* | ||
* Copyright (c) 2023, NVIDIA CORPORATION. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
#include <sstream> | ||
#include <string> | ||
|
||
#include <raft/core/device_resources.hpp> | ||
#include <raft/neighbors/ivf_flat_serialize.cuh> | ||
#include <raft/neighbors/ivf_flat_types.hpp> | ||
#include <raft_runtime/neighbors/ivf_flat.hpp> | ||
|
||
namespace raft::runtime::neighbors::ivf_flat { | ||
|
||
#define RAFT_IVF_FLAT_SERIALIZE_INST(DTYPE) \ | ||
void serialize_file(raft::resources const& handle, \ | ||
const std::string& filename, \ | ||
const raft::neighbors::ivf_flat::index<DTYPE, int64_t>& index) \ | ||
{ \ | ||
raft::neighbors::ivf_flat::serialize(handle, filename, index); \ | ||
}; \ | ||
\ | ||
void deserialize_file(raft::resources const& handle, \ | ||
const std::string& filename, \ | ||
raft::neighbors::ivf_flat::index<DTYPE, int64_t>* index) \ | ||
{ \ | ||
if (!index) { RAFT_FAIL("Invalid index pointer"); } \ | ||
*index = raft::neighbors::ivf_flat::deserialize<DTYPE, int64_t>(handle, filename); \ | ||
}; \ | ||
void serialize(raft::resources const& handle, \ | ||
std::string& str, \ | ||
const raft::neighbors::ivf_flat::index<DTYPE, int64_t>& index) \ | ||
{ \ | ||
std::stringstream os; \ | ||
raft::neighbors::ivf_flat::serialize(handle, os, index); \ | ||
str = os.str(); \ | ||
} \ | ||
\ | ||
void deserialize(raft::resources const& handle, \ | ||
const std::string& str, \ | ||
raft::neighbors::ivf_flat::index<DTYPE, int64_t>* index) \ | ||
{ \ | ||
std::istringstream is(str); \ | ||
if (!index) { RAFT_FAIL("Invalid index pointer"); } \ | ||
*index = raft::neighbors::ivf_flat::deserialize<DTYPE, int64_t>(handle, is); \ | ||
} | ||
|
||
RAFT_IVF_FLAT_SERIALIZE_INST(float); | ||
RAFT_IVF_FLAT_SERIALIZE_INST(int8_t); | ||
RAFT_IVF_FLAT_SERIALIZE_INST(uint8_t); | ||
|
||
#undef RAFT_IVF_FLAT_SERIALIZE_INST | ||
} // namespace raft::runtime::neighbors::ivf_flat |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is not used by the current PR (only (de)serialize_file is used). But I think this can be used to fix rapidsai/cuml#4743, that motivates to keep it in the PR.