Sparse Pairwise Distances API Updates #1502
Conversation
divyegala
added
improvement
divyegala
added
breaking
| static_cast<value_idx>(params.indptr_h.size() - 1), | ||
| static_cast<value_idx>(params.indptr_h.size() - 1)); | ||
|
|
||
| auto x_structure = raft::make_device_compressed_structure_view<value_idx, value_idx, value_idx>( |
There was a problem hiding this comment.
This is a mouthfull and one of the reasons I opted to shorten it to csr_structure instead of spelling it all out. I wonder if there's another verbiage we can use that might still be consistent with other factory naming conventions but be a little shorter. Not a huge deal, but seeing the function name take up most of this long line of code here is a little concerning.
There was a problem hiding this comment.
You are right, it is a little verbose. I cannot think of another verbiage off the top of my head right now
| template <typename DeviceCSRMatrix, | ||
| typename ElementType, | ||
| typename IndexType, | ||
| typename = std::enable_if_t<raft::is_device_csr_sparsity_preserving_v<DeviceCSRMatrix>>> |
There was a problem hiding this comment.
This should probalby accept sparsity-owning as well, right? The requirement is just that the sparsity has been initialized.
There was a problem hiding this comment.
It will accept a view obtained from a sparsity owning matrix. I made changes to the meta functions in this PR itself to make that work
|
/merge |
From rapidsai/raft#1502 Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #5428
No description provided.