Remove raft/matrix/matrix.cuh includes #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `raft/matrix/matrix.cuh` file has been marked as deprecated, and produces a compile warning when included. However it was still being referenced in a bunch of different spots within raft - making it hard to avoid these warnings. Remove the includes, in favour of either the newer API's or in certain cases the detail API
|
Oh man this makes me so happy. Thanks @benfred for taking this on! |
cjnolet
requested changes
May 9, 2023
benfred
added
improvement
benfred
added a commit
to benfred/cuml
that referenced
this pull request
May 9, 2023
cjnolet
approved these changes
May 10, 2023
| * @param[out] out: output matrix | ||
| */ | ||
| template <typename m_t, typename matrix_idx_t> | ||
| void copy(raft::device_resources const& handle, |
| @@ -34,7 +34,7 @@ namespace raft::matrix { | |||
| * @param[out] matrix: matrix of size n_rows x n_cols | |||
| */ | |||
| template <typename m_t, typename idx_t, typename layout> | |||
| void set_diagonal(raft::device_resources const& handle, | |||
| void set_diagonal(raft::resources const& handle, | |||
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
May 11, 2023
Required to build after change rapidsai/raft#1498 is merged Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #5411
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
raft/matrix/matrix.cuhfile has been marked as deprecated, and produces a compile warning when included. However it was still being referenced in a bunch of different spots within raft - making it hard to avoid these warnings.Remove the includes, in favour of either the newer API's or in certain cases the detail API