Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ext declaration for log detail::format #1482

Merged
merged 4 commits into from
May 4, 2023
Merged

Add missing ext declaration for log detail::format #1482

merged 4 commits into from
May 4, 2023

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented May 2, 2023

The format function is used by debug and trace loggers. While PR #1469 has restructured the logger headers it was forgotten to expose detail::format in case the RAFT_EXPLICIT_INSTANTIATE_ONLY is defined. This PR fixes that.

@tfeher tfeher requested a review from a team as a code owner May 2, 2023 10:26
@tfeher tfeher requested a review from ahendriksen May 2, 2023 10:26
@github-actions github-actions bot added the cpp label May 2, 2023
@tfeher
Copy link
Contributor Author

tfeher commented May 2, 2023

Tagging @ahendriksen for review.

We should update the test so that such problems do not go undetected. The problem is, by default the debug and trace logging are disabled by RAFT_ACTIVE_LEVEL. Shall we just define adequate active level for the unit test?

@tfeher tfeher added bug Something isn't working non-breaking Non-breaking change labels May 2, 2023
@tfeher tfeher self-assigned this May 2, 2023
ahendriksen
ahendriksen approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@ahendriksen ahendriksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I overlooked the detail namespace because I thought it would not get called from outside code..

@ahendriksen
Copy link
Contributor

Shall we just define adequate active level for the unit test?

I agree it makes sense to #define RAFT_ACTIVE_LEVEL=6 at the top of the logger test (i.e. before including logger.hpp). It would be even nicer if we could use RAFT_LEVEL_TRACE instead of 6, but that would require including logger.hpp.

tfeher
tfeher commented May 2, 2023
View reviewed changes
Copy link
Contributor Author

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Allard for the suggestion!

cpp/include/raft/core/logger-ext.hpp Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member

cjnolet commented May 4, 2023

/merge

@rapids-bot rapids-bot bot merged commit 212cfe9 into rapidsai:branch-23.06 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@ahendriksen ahendriksen ahendriksen approved these changes

Assignees

@tfeher tfeher

Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfeher @ahendriksen @cjnolet