Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove include statements from inside namespace #1467

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions cpp/include/raft/core/detail/nvtx.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@

#include <rmm/cuda_stream_view.hpp>

namespace raft::common::nvtx::detail {

#ifdef NVTX_ENABLED

#include <cstdint>
Expand All @@ -30,6 +28,8 @@ namespace raft::common::nvtx::detail {
#include <type_traits>
#include <unordered_map>

namespace raft::common::nvtx::detail {

/**
* @brief An internal struct to store associated state with the color
* generator
Expand Down Expand Up @@ -191,8 +191,12 @@ inline void pop_range()
nvtxDomainRangePop(domain_store<Domain>::value());
}

} // namespace raft::common::nvtx::detail

#else // NVTX_ENABLED

namespace raft::common::nvtx::detail {

template <typename Domain, typename... Args>
inline void push_range(const char* format, Args... args)
{
Expand All @@ -203,6 +207,6 @@ inline void pop_range()
{
}

#endif // NVTX_ENABLED

} // namespace raft::common::nvtx::detail

#endif // NVTX_ENABLED