Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dim param for IVF-PQ wrapper in ANN bench #1427

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Fix dim param for IVF-PQ wrapper in ANN bench #1427

merged 1 commit into from
Apr 18, 2023

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Apr 18, 2023

The index_ is not yet initialized. To construct the dataset view, we need to use the dim_ variable which was set in the constructor.

@tfeher tfeher added bug Something isn't working non-breaking Non-breaking change labels Apr 18, 2023
@tfeher tfeher self-assigned this Apr 18, 2023
@tfeher tfeher requested a review from a team as a code owner April 18, 2023 07:21
@github-actions github-actions bot added the cpp label Apr 18, 2023
@cjnolet
Copy link
Member

cjnolet commented Apr 18, 2023

/merge

@rapids-bot rapids-bot bot merged commit ff58b8b into rapidsai:branch-23.06 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@tfeher tfeher

Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfeher @cjnolet