Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have consistent compile lines between BUILD_TESTS enabled or not #1401

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Have consistent compile lines between BUILD_TESTS enabled or not #1401

merged 1 commit into from
Apr 7, 2023

Conversation

robertmaynard
Copy link
Contributor

This will remove 1h from our conda CI builds since we can now re-use the cached object files between libraft and libraft-tests

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Apr 6, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner April 6, 2023 16:39
vyasr
vyasr approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@robertmaynard
Copy link
Contributor Author

Do we have a workaround/PR for the dask-cuda==23.6.0a0+10.g80596bd and distributed 2023.3.2+29.g1ccc312a conflict I am getting in the wheel builds?

@divyegala
Copy link
Member

Do we have a workaround/PR for the dask-cuda==23.6.0a0+10.g80596bd and distributed 2023.3.2+29.g1ccc312a conflict I am getting in the wheel builds?

@galipremsagar is this similar to what is happening in other repos?

@galipremsagar
Copy link
Contributor

Do we have a workaround/PR for the dask-cuda==23.6.0a0+10.g80596bd and distributed 2023.3.2+29.g1ccc312a conflict I am getting in the wheel builds?

@galipremsagar is this similar to what is happening in other repos?

Yes, 23.06 is blocked until this is merged: #1403

@galipremsagar
Copy link
Contributor

galipremsagar commented Apr 6, 2023 •
edited
Loading

UPDATE: CI should now be unblocked. @robertmaynard you can merge the branch-23.06 changes into your PR.

@robertmaynard
Have consistent compile lines between BUILD_TESTS enabled or not
871e0da 
This will remove 1h from our conda CI builds since we can now
re-use the cached object files between `libraft` and `libraft-tests`
@robertmaynard robertmaynard force-pushed the bug/libraft_not_effected_by_building_tests branch from ee90cf5 to 871e0da Compare April 6, 2023 21:36
@robertmaynard
Copy link
Contributor Author

UPDATE: CI should now be unblocked. @robertmaynard you can merge the branch-23.06 changes into your PR.

Thanks!

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9048dff into rapidsai:branch-23.06 Apr 7, 2023
@robertmaynard robertmaynard deleted the bug/libraft_not_effected_by_building_tests branch April 7, 2023 12:22
ahendriksen pushed a commit to ahendriksen/raft that referenced this pull request Apr 14, 2023
@robertmaynard @ahendriksen
Have consistent compile lines between BUILD_TESTS enabled or not (rap…
b657569 
…idsai#1401)

This will remove 1h from our conda CI builds since we can now re-use the cached object files between `libraft` and `libraft-tests`

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Ben Frederickson (https://github.com/benfred)
  - Divye Gala (https://github.com/divyegala)

URL: rapidsai#1401
ahendriksen pushed a commit to ahendriksen/raft that referenced this pull request Apr 18, 2023
@robertmaynard @ahendriksen
Have consistent compile lines between BUILD_TESTS enabled or not (rap…
6ad9d95 
…idsai#1401)

This will remove 1h from our conda CI builds since we can now re-use the cached object files between `libraft` and `libraft-tests`

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Ben Frederickson (https://github.com/benfred)
  - Divye Gala (https://github.com/divyegala)

URL: rapidsai#1401
ahendriksen pushed a commit to ahendriksen/raft that referenced this pull request Apr 18, 2023
@robertmaynard @ahendriksen
Have consistent compile lines between BUILD_TESTS enabled or not (rap…
facb5d2 
…idsai#1401)

This will remove 1h from our conda CI builds since we can now re-use the cached object files between `libraft` and `libraft-tests`

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Ben Frederickson (https://github.com/benfred)
  - Divye Gala (https://github.com/divyegala)

URL: rapidsai#1401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@vyasr vyasr vyasr approved these changes

@benfred benfred benfred approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review bug Something isn't working CMake cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robertmaynard @divyegala @galipremsagar @benfred @vyasr