Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small follow-up to specializations cleanup #1332

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Mar 11, 2023

Just making sure the knn bench will properly compile even if only the distance library is compiled.

@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Mar 11, 2023
@cjnolet cjnolet self-assigned this Mar 11, 2023
@github-actions github-actions bot removed the CMake label Mar 11, 2023
@cjnolet cjnolet marked this pull request as ready for review March 11, 2023 21:12
@cjnolet cjnolet requested a review from a team as a code owner March 11, 2023 21:12
@cjnolet
Copy link
Member Author

cjnolet commented Mar 12, 2023

/merge

@rapids-bot rapids-bot bot merged commit b12fc82 into rapidsai:branch-23.04 Mar 12, 2023
lowener pushed a commit to lowener/raft that referenced this pull request Mar 15, 2023
Just making sure the knn bench will properly compile even if only the distance library is compiled.

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Ben Frederickson (https://github.com/benfred)

URL: rapidsai#1332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

2 participants