Using int64_t specializations for ivf_pq and refine
#1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
benfred
approved these changes
Mar 9, 2023
|
This is fixing a bug in cuml and I don't believe any existing users will be negatively impacted by the changes to the specialized types so I'm going to go ahead and merge this over. |
|
/merge |
lowener
pushed a commit
to lowener/raft
that referenced
this pull request
Mar 15, 2023
Since FAISS and Milvus are both using `int64_t` everywhere and we haven't explicitly encountered places where `uint64_t` is being used for ann indices, we're opting to just use `int64_t` instead. Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Ben Frederickson (https://github.com/benfred) URL: rapidsai#1325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since FAISS and Milvus are both using
int64_teverywhere and we haven't explicitly encountered places whereuint64_tis being used for ann indices, we're opting to just useint64_tinstead.