Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream overloads to ivf_pq serialize/deserialize methods #1315

Merged
merged 6 commits into from
Mar 7, 2023

Conversation

divyegala
Copy link
Member

No description provided.

@divyegala divyegala added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cpp labels Mar 6, 2023
@divyegala divyegala requested a review from a team as a code owner March 6, 2023 18:06
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rapidsai rapidsai deleted a comment from wphicks Mar 7, 2023
@cjnolet
Copy link
Member

cjnolet commented Mar 7, 2023

@wphicks I know you are anxious to get these changes merged but they aren't complete quite yet. Please let Divye finish exposing these APIs publicly and adding the usage examples.

@divyegala I'm requesting changes in the meantime just to stop from auto-merging.

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes until the PR is ready to be merged.

@divyegala divyegala requested a review from cjnolet March 7, 2023 13:50
@cjnolet
Copy link
Member

cjnolet commented Mar 7, 2023

/merge

@rapids-bot rapids-bot bot merged commit 3ca7eac into rapidsai:branch-23.04 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants